fix(windows-installer): add new cleanup script on install - Githubissues

runfinch / finch

The Finch CLI is an open source client for container development

https://www.runfinch.com

Apache License 2.0

3.48k stars 87 forks source link

fix(windows-installer): add new cleanup script on install #824

Closed pendo324 closed 4 months ago

pendo324 commented 4 months ago

Issue #, if available:

Description of changes:

Add new script that runs upon installation to cleanup any dangling Finch VM
- This is needed because earlier versions of Finch's Windows installer don't clean up properly on uninstall / reinstall
- Even with this change, user's will be prompted to stop limactl on reinstall if Finch is running. Regardless of which action they choose, the install script will cleanup any dangling VMs.

Testing done:

Tested locally
[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pendo324 commented 4 months ago

Overriding as regular CI tests don't validate Windows installers.