Open bestickley opened 3 months ago
Actually, removing "credsStore": "ecr-login",
breaks finch pull
using AWS Creds based on your profile.
But then that breaks CDK. So I'm not sure how to create a solution that solves both cases :(
Is there any way for finch pull
to use AWS creds but to also allow commands like finch login --username AWS --password-stdin https://905418358903.dkr.ecr.us-east-1.amazonaws.com
to work?
This issues seems related: https://github.com/awslabs/amazon-ecr-credential-helper/issues/102
What is the problem you're trying to solve?. I want to use amazon-ecr-credential-helper and CDK DockerImageAsset with the default finch configuration when setting in ~/.finch/finch.yml:
The issue is that this is the default ~/.finch/config.json
which results in:
The root issue seems to be
"credsStore": "ecr-login",
. When I remove it, CDK can deploy no problem and my ~/.finch/config.json then looks like:Describe the feature you'd like Fix finch configuration to be compatible with CDK
DockerImageAsset
Additional context Add any other context or screenshots about the feature request here.