runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.51k stars 90 forks source link

Support bundle fails to be created on Windows #897

Closed pendo324 closed 1 month ago

pendo324 commented 5 months ago

Describe the bug On Windows, running finch support-bundle generate fails with the following error:

level=fatal msg="exec: \"uname\": executable file not found in %PATH%"

Steps to reproduce Run finch support-bundle generate on Windows.

Expected behavior A support bundle should be created.

Screenshots or logs If applicable, add screenshots or logs to help explain your problem.

Additional context The reason this issue occurs is because pkg/support/support.go's getArch function calls uname on the host system, and Windows does not have a uname executable.

getArch should be scoped to OS-specific files for UNIX and Windows.

To help debug the issue as quickly as possible, we recommend generating a support bundle with finch support-bundle generate and attaching it to this issue. This packages all Finch-related configs and logs into one file.

pendo324 commented 1 month ago

Resolved by #976