Description of changes:
Previously, if the process didn't exist, the taskkill command would fail, which would cause the entire workflow step to fail. This is because although $ErrorActionPreference = 'Ignore' is set, it doesn't actually work for sessions, only individual commands
Testing done:
Tested the output of $LASTEXITCODE after running the commands manually, got 0
[x] I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: https://github.com/runfinch/finch/actions/runs/8659666232/job/23746037924
Description of changes: Previously, if the process didn't exist, the
taskkill
command would fail, which would cause the entire workflow step to fail. This is because although$ErrorActionPreference = 'Ignore'
is set, it doesn't actually work for sessions, only individual commandsTesting done:
Tested the output of
$LASTEXITCODE
after running the commands manually, got 0[x] I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.