runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.47k stars 87 forks source link

ci: fix taskkill error #898

Closed pendo324 closed 2 months ago

pendo324 commented 2 months ago

Issue #, if available: https://github.com/runfinch/finch/actions/runs/8659666232/job/23746037924

Description of changes: Previously, if the process didn't exist, the taskkill command would fail, which would cause the entire workflow step to fail. This is because although $ErrorActionPreference = 'Ignore' is set, it doesn't actually work for sessions, only individual commands

Testing done:

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.