search

runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.47k stars 87 forks source link

feat: Add the --format option to the finch version command #926

Closed haytok closed 1 month ago

haytok commented 2 months ago

Currently, the finch version command does not support the --format option.

However, a feature request has been submitted in the following issue to add the --format option to the finch version command.

Therefore, this fix introduces the --format option to the finch version command.

Issue #, if available:

Description of changes: Details are described in this commit message.

Testing done: Yes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

haytok commented 2 months ago

The e2e tests related to the finch version command that I modified are currently failing, so I'll fix them. 

Summarizing 1 Failure:
  [FAIL]  Check finch version [It] Should print finch version information
  /Users/ec2-user/ar/_work/finch/finch/e2e/vm/version_test.go:73

I'll particularly re-examine the following areas.

haytok commented 2 months ago

The e2e tests for the finch version command were failing due to the following refactored part when outputting finch version.

According to the template syntax, this commit required changing the output order of GitCommit and OS/Arch.

The e2e tests also needed to be update, so I'll update the e2e tests.

pendo324 commented 1 month ago

Also, this should probably be a feat: tag instead of a fix:, since its a new feature

haytok commented 1 month ago

Hi, @pendo324

Thanks for review!!! I have added the docs and amended the commit message title. Could you please review it again?

haytok commented 1 month ago

Thanks for approving this PR. I'll merge this :)