runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.47k stars 87 forks source link

chore: update Amazon ECR credential helper to v0.8.0 #944

Closed austinvazquez closed 1 month ago

austinvazquez commented 1 month ago

Issue #, if available: N/A

Description of changes: This change updates the Amazon ECR credential helper to v0.8.0

full diff: https://github.com/awslabs/amazon-ecr-credential-helper/compare/v0.7.1...v0.8.0

Testing done:

Validated 0.8.0 is installed in local finch build.

macedonv@localhost:~/finch$ LIMA_HOME=/Users/macedonv/finch/_output/lima/data/ /Users/macedonv/finch/_output/lima/bin/limactl shell finch
[macedonv@lima-finch finch]$ docker-credential-ecr-login version
docker-credential-ecr-login (github.com/awslabs/amazon-ecr-credential-helper/ecr-login) 0.8.0
[macedonv@lima-finch finch]$ 

Pulled image use credential helper as authorizer.

macedonv@localhost:~/finch$ ./_output/bin/finch run -it <redacted>.dkr.ecr.us-west-2.amazonaws.com/hello-world
<redacted>.dkr.ecr.us-west-2.amazonaws.com/hello-world:latest:                  resolved       |++++++++++++++++++++++++++++++++++++++| 
manifest-sha256:35393f104f0b077ee6ba7cf86afeae1663e03de19e05d59c748ae82cf928cba0: done           |++++++++++++++++++++++++++++++++++++++| 
config-sha256:efcdebc4572d389f890c8ccfc19622fe2f5f660bec6eb7be979380e54de1dae0:   done           |++++++++++++++++++++++++++++++++++++++| 
layer-sha256:31e352740f534f9ad170f75378a84fe453d6156e40700b882d737a8f4a6988a3:    exists         |++++++++++++++++++++++++++++++++++++++| 
elapsed: 3.5 s                                                                    total:  1.6 Ki (461.0 B/s)                                       
Hello world
macedonv@localhost:~/finch$ 

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pendo324 commented 1 month ago

@austinvazquez Looks like the "configure AWS credentials" step got skipped in the e2e tests, so I don't think the credential helper ever actually got used. Did you at least do a smoke test manually?

austinvazquez commented 1 month ago

@pendo324, oh good catch. Let me manual test using a local build and update the description with the results.

austinvazquez commented 1 month ago

@pendo324, updated description with testing. PTAL.