Builds are failing when running on older versions of macOS due to the new dependency on yq, which we install via brew. It is possible to install this dependency through other means (curling / chmoding / moving), but this seems like a better long-term solution.
Description of changes:
Removes the need to build finch on macOS 11. This was previously done so that our binaries would be compatible with older versions of macOS. However, we can get around this by using the CGO flags that are in this diff, entirely removing the need to build on older macOS versions. In the future, these hosts can be completely dropped from the CI as well, as macOS 11 is no longer one of the 2 most recent versions of macOS.
Going forward, it may be possible to use something like crazy-max/xgo or crazy-max/goxx, with the osxcross toolchain to containerize builds of Finch, making them more reproducible and removing the need for macOS build/release hosts entirely.
Testing done:
Verified finch binaries built on macOS 14 run properly on macOS 11 hosts
Since this isn't obvious, this is how you can at least test that the compiler used the flags:
Issue #, if available:
Description of changes:
CGO
flags that are in this diff, entirely removing the need to build on older macOS versions. In the future, these hosts can be completely dropped from the CI as well, as macOS 11 is no longer one of the 2 most recent versions of macOS.Testing done:
Verified finch binaries built on macOS 14 run properly on macOS 11 hosts
Since this isn't obvious, this is how you can at least test that the compiler used the flags:
[x] I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.