runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.47k stars 87 forks source link

ci(refactor): split build-and-test-pkg for better reuse #953

Closed pendo324 closed 1 month ago

pendo324 commented 1 month ago

Issue #, if available:

Description of changes: While I was fixing the macOS pkg build error on macOS 11 (due to yq from brew not building properly), I noticed that most of the file was repeated (due to different archs being built/tested as different jobs) which caused it to be pretty unnecessarily unwieldy. This was the case for both the build and the test workflow jobs.

I initially thought I could combine them using matrices, but then we lose the ability to run the test jobs as soon as each respective build completes (with a matrix, it would have to wait until both builds complete, which isn't even guaranteed). There were other complications that made matrices hard, like the fact that we only want to build once per arch, but we want to test on several other arch/version combinations.

Instead, I was able to split the workflows into reusable/composite workflows, so that only the inputs vary, and the script is mostly the same.

Testing done:

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pendo324 commented 1 month ago

Release action run test. It gets past the previously failing step (Install build dependencies) https://github.com/runfinch/finch/actions/runs/9130235009/job/25107445223