runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.47k stars 87 forks source link

fix: Remove unnecessary error handling #961

Closed haytok closed 1 month ago

haytok commented 1 month ago

Inside the ConfigureDefaultLimaYaml() function, there is a process to write to the config file as follows:

```
if err := afero.WriteFile(lca.fs, lca.limaDefaultConfigPath, limaCfgBytes, 0o600); err != nil {
    return fmt.Errorf("failed to write to the lima config file: %w", err)
}

if err != nil {
    return fmt.Errorf("unable to apply override config: %w", err)
}
```

The current implementation has two error checks to determine if the file can be written.

The err object in the second part is guaranteed to be nil due to the previous if statement.

Therefore, this fix removes the unnecessary second error check.

Issue #, if available: N/A

Description of changes: The details are described in this commit message.

Testing done: N/A

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.