runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.51k stars 91 forks source link

fix: Enable `finch support-bundle generate` to execute on Windows whe… #976

Closed haytok closed 3 months ago

haytok commented 3 months ago

…re the uname command does not exist

On Windows environments where the uname command is not available, executing finch support-bundle generate results in the following error:

C:\Users\simpl>"..\..\Program Files\Finch\bin\finch.exe" support-bundle generate
time="2024-06-11T23:21:16+09:00" level=info msg="Generating support bundle..."
time="2024-06-11T23:21:16+09:00" level=fatal msg="exec: \"uname\": executable file not found in %PATH%"

This bug has been reported in the following issue:

Therefore, this fix enables the execution of finch support-bundle generate even when the uname command is not available on Windows.

Issue #, if available: #897

Description of changes: The details are described in this commit message.

Testing done: Yes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.