search

rungwiroon / BlazorGoogleMaps

Blazor interop for GoogleMap library
MIT License
319 stars 102 forks source link

Marker Collision processing broken in v3.0.6 #263

Closed joe-shapiro-biz closed 1 year ago

joe-shapiro-biz commented 1 year ago

with latest release, getting the above error in console. Note case of "optionaL_"

valentasm1 commented 1 year ago

Could you give a bit more information?

joe-shapiro-biz commented 1 year ago

Blazor wasm project. Error occurs while drawing initial markers, with clusterer. Does not happen in production .net 6 environment but does in dev .net 7 environment. This is the code…

        var opts = new MarkerOptions()
        {
            Label = label,
            Visible = MarkerVisible,
            Position = position,
            Clickable = true,
            // jds THIS ONE
            CollisionBehavior = CollisionBehavior.REQUIRED_AND_HIDES_OPTIONAL,
            ZIndex = 99,
            Map = _Map.InteropObject,
            Icon = icon,
            Title = Title
        };

        var mk = await Marker.CreateAsync(_Map.JsRuntime, opts);

From: Valentas @.> Sent: Wednesday, May 31, 2023 11:51 AM To: rungwiroon/BlazorGoogleMaps @.> Cc: Joe Shapiro @.>; Author @.> Subject: Re: [rungwiroon/BlazorGoogleMaps] setCollisionBehavior: optionaL_AND_HIDES_LOWER_PRIORITY is not an accepted value (Issue #263)

Could you give a bit more information?

— Reply to this email directly, view it on GitHubhttps://github.com/rungwiroon/BlazorGoogleMaps/issues/263#issuecomment-1570493390, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEE4OLOTRPXEM72B7GU6GITXI5SHDANCNFSM6AAAAAAYVVF2ZQ. You are receiving this because you authored the thread.Message ID: @.**@.>>

valentasm1 commented 1 year ago

Sorry but unable to reproduce with our wasm sample nor in .net 6, nor .net 7. Would need minimal project

joe-shapiro-biz commented 1 year ago

Project works with v2.5.7, fails with v3.0.6 I will try to find the time to create a minimal project.

From: Valentas @.> Sent: Wednesday, May 31, 2023 1:02 PM To: rungwiroon/BlazorGoogleMaps @.> Cc: Joe Shapiro @.>; Author @.> Subject: Re: [rungwiroon/BlazorGoogleMaps] setCollisionBehavior: optionaL_AND_HIDES_LOWER_PRIORITY is not an accepted value (Issue #263)

Sorry but unable to reproduce with our wasm sample nor in .net 6, nor .net 7. Would need minimal project

— Reply to this email directly, view it on GitHubhttps://github.com/rungwiroon/BlazorGoogleMaps/issues/263#issuecomment-1570594648, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEE4OLMLRLVDX3DKD74GXLTXI52QFANCNFSM6AAAAAAYVVF2ZQ. You are receiving this because you authored the thread.Message ID: @.**@.>>

joe-shapiro-biz commented 1 year ago

required.zip run this and look at the javascript console.

then comment out this line in Map.razor and do it again... CollisionBehavior = CollisionBehavior.REQUIRED_AND_HIDES_OPTIONAL,

joe-shapiro-biz commented 1 year ago

(and, of course, the collision processing does not work under these circumstances)

valentasm1 commented 1 year ago

I think it come down from &v=beta . It should be &v=3 Sorry but i dont want to try make it work with beta version. Who knows. Maybe with production version it will start working

valentasm1 commented 1 year ago

Also thank you for demo project. I know it takes time

joe-shapiro-biz commented 1 year ago

Marker collision is only available in v=beta. V=3 turns off the feature altogether, hiding the problem.

From: Valentas @.> Sent: Sunday, June 4, 2023 1:50:05 PM To: rungwiroon/BlazorGoogleMaps @.> Cc: Joe Shapiro @.>; Author @.> Subject: Re: [rungwiroon/BlazorGoogleMaps] Marker Collision processing broken in v3.0.6 (was optionaL_AND_HIDES_LOWER_PRIORITY ) (Issue #263)

Also thank you for demo project. I know it takes time

— Reply to this email directly, view it on GitHubhttps://github.com/rungwiroon/BlazorGoogleMaps/issues/263#issuecomment-1575655222, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEE4OLJOBATRU4WFXKZNSKDXJTDE3ANCNFSM6AAAAAAYVVF2ZQ. You are receiving this because you authored the thread.Message ID: @.***>

joe-shapiro-biz commented 1 year ago

https://developers.google.com/maps/documentation/javascript/examples/marker-collision-management

From: Joe Shapiro @.> Sent: Sunday, June 4, 2023 2:04:54 PM To: rungwiroon/BlazorGoogleMaps @.>; rungwiroon/BlazorGoogleMaps @.> Cc: Author @.> Subject: Re: [rungwiroon/BlazorGoogleMaps] Marker Collision processing broken in v3.0.6 (was optionaL_AND_HIDES_LOWER_PRIORITY ) (Issue #263)

Marker collision is only available in v=beta. V=3 turns off the feature altogether, hiding the problem.

From: Valentas @.> Sent: Sunday, June 4, 2023 1:50:05 PM To: rungwiroon/BlazorGoogleMaps @.> Cc: Joe Shapiro @.>; Author @.> Subject: Re: [rungwiroon/BlazorGoogleMaps] Marker Collision processing broken in v3.0.6 (was optionaL_AND_HIDES_LOWER_PRIORITY ) (Issue #263)

Also thank you for demo project. I know it takes time

— Reply to this email directly, view it on GitHubhttps://github.com/rungwiroon/BlazorGoogleMaps/issues/263#issuecomment-1575655222, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEE4OLJOBATRU4WFXKZNSKDXJTDE3ANCNFSM6AAAAAAYVVF2ZQ. You are receiving this because you authored the thread.Message ID: @.***>

valentasm1 commented 1 year ago

Related https://github.com/rungwiroon/BlazorGoogleMaps/issues/127

valentasm1 commented 1 year ago

Thank you for not giving up. There was huge migration from json.net to system.text.json so in that step it was lost some enum serializations. https://www.nuget.org/packages/BlazorGoogleMaps/3.0.7

joe-shapiro-biz commented 1 year ago

Thank you

From: Valentas @.> Sent: Friday, June 9, 2023 3:34:26 AM To: rungwiroon/BlazorGoogleMaps @.> Cc: Joe Shapiro @.>; Author @.> Subject: Re: [rungwiroon/BlazorGoogleMaps] Marker Collision processing broken in v3.0.6 (Issue #263)

Thank you for not giving up. There was huge migration from json.net to system.text.json so in that step it was lost some enum serializations. https://www.nuget.org/packages/BlazorGoogleMaps/3.0.7

— Reply to this email directly, view it on GitHubhttps://github.com/rungwiroon/BlazorGoogleMaps/issues/263#issuecomment-1584111598, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEE4OLMZ2JMDCQTMXYDTWV3XKLGYFANCNFSM6AAAAAAYVVF2ZQ. You are receiving this because you authored the thread.Message ID: @.***>

joe-shapiro-biz commented 5 months ago

Sorry to bother you.

I am confused. I think that maybe BlazorGoogleMaps now supports the google advanced marker, but I do not see it anywhere when I download the code.

Does it support advanced markers? Are there any instructions?

Thanks again, Joe.

valentasm1 commented 5 months ago

There is sample page. I am sure it missing some functionality. https://github.com/rungwiroon/BlazorGoogleMaps/blob/master/ServerSideDemo/Pages/AdvancedMarkerViewPage.razor