rungwiroon / BlazorGoogleMaps

Blazor interop for GoogleMap library
MIT License
325 stars 105 forks source link

Run js quality check with ChatGpt or similar quality tool #341

Closed valentasm1 closed 2 months ago

valentasm1 commented 3 months ago

Better finish or add more test in test-all page and only then do js cleanup/optimization

valentasm1 commented 3 months ago

https://www.nuget.org/packages/BlazorGoogleMaps/4.7.0

vinco83 commented 3 months ago

This seems to have broken some stuff, at least for me.

It removed the checks that google.maps.places != undefined, i.e.

google.maps.places !== undefined && obj instanceof google.maps.places.PlacesService

This is causing an exception.

valentasm1 commented 3 months ago

What about now https://www.nuget.org/packages/BlazorGoogleMaps/4.7.1

vinco83 commented 3 months ago

That fixed it, thank you!

Although now I'm receiving a different exception. It's unrelated to this, I believe--creating a new Issue to ask for help