search

rungwiroon / BlazorGoogleMaps

Blazor interop for GoogleMap library
MIT License
331 stars 105 forks source link

Adding ability to make AdvancedMarkerElement Glyphs HTML content. #350

Closed Eddie-Hartman closed 2 months ago

Eddie-Hartman commented 2 months ago

I had mentioned in this comment: https://github.com/rungwiroon/BlazorGoogleMaps/issues/338#issuecomment-2267200750 I was unable to set PinElement Glyphs to HTML content properly.

After looking through the updates to objectManager.js in this commit: https://github.com/rungwiroon/BlazorGoogleMaps/commit/01fd96e93b11a56c341940f6fd95a069847e2eb5

I was able to understand that my suspicion was correct and only image URLs and text were currently supported.

I copied the above code for making an HTML element for pins to allow the same for PinElement Glyphs and it worked fine.

Before: image After: image

First PR to this repo and I definitely don't understand everything going on in here, but was able to piece enough together here. I also tried to follow the codebase conventions. Feel free to make any additional modifications you see fit to get this feature in.

Eddie-Hartman commented 2 months ago

FWIW, I did see that the other changes used a template element instead of a div as the root. That may be preferred, but I was just going off of Google's example as linked in my original comment, but wanted to call it out as a difference since you may prefer it.

valentasm1 commented 2 months ago

Thank you for taking time for PR.

https://www.nuget.org/packages/BlazorGoogleMaps/4.7.5