search

running-elephant / datart

Datart is a next generation Data Visualization Open Platform
https://running-elephant.github.io/datart-docs/
Apache License 2.0
1.99k stars 591 forks source link

Waterfall chart total description lacks i18n support #1554

Closed clementchong closed 2 years ago

clementchong commented 2 years ago

Datart Version Demo site 1.0.0b3

Describe the bug The total label is hardcoded to chinese.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior It should display in selected language.

Screenshots image

Environmental details: (optional, depending on where the bug occurs)

Additional context Add any other context about the problem here.

clementchong commented 2 years ago

2 more hardcoding in the chart mouseover popup.

For my own reference, file to change is https://github.com/running-elephant/datart/blob/dev/frontend/src/app/components/ChartGraph/WaterfallChart/WaterfallChart.tsx

image

Cuiyansong commented 2 years ago

Right, not just one place, will fixed.

clementchong commented 2 years ago

Thank you!

clementchong commented 2 years ago

Looks good in beta 4, thank you!

image