search

runningcode / gradle-doctor

The right prescription for your Gradle build.
http://runningcode.github.io/gradle-doctor
Apache License 2.0
736 stars 48 forks source link

Add warning for enabling build cache? #177

Closed ColtonIdle closed 1 year ago

ColtonIdle commented 2 years ago

Watching this: https://youtu.be/S_zZRBJxTQ0?t=201

And I thought I had build cache enabled... but I didn't. Would've thought gradle doctor would've warned me about it? What do you think runningcode ?

oheyadam commented 2 years ago

It's currently an experimental feature so I'm not sure how he'd feel about including it.

dsvoronin commented 2 years ago

@ColtonIdle it's not clear what cache exactly do you mean. Video starts with last seconds of lint caching section and then goes about configuration cache

general org.gradle.caching=true is not experimental and could be a subject for a warning indeed, but configuration cache is experimental and it looks like your issue description confused @oheyadam

ColtonIdle commented 2 years ago

I paused at the timestamp I linked above. You can see that it is talking about gradel build cache.

Sorry for the confusion.

Screen Shot 2021-11-01 at 3 19 31 PM
runningcode commented 2 years ago

I think this warning would generate too many false positives and would not be useful. I have not yet come across an Android project that did not already have this enabled since the default Android Studio template adds this.

ColtonIdle commented 2 years ago

Really? I created a new project about a month ago and it did not have this, hence why I created this issue. I'm using the AS canaries exclusively... I wonder if something was up with that.

It's fine to close if you think there'd be too many false positives. Thanks Nelson