Compare bin subdirs of java home on root mismatch [fix 187]

runningcode / gradle-doctor

The right prescription for your Gradle build.

http://runningcode.github.io/gradle-doctor

Apache License 2.0

736 stars 48 forks source link

Compare bin subdirs of java home on root mismatch [fix 187] #240

Closed Rattenkrieg closed 1 year ago

Rattenkrieg commented 1 year ago

Fixes #187 We can take it further and resolve and compare other known java dirs ie lib, jre. However I believe bin is sufficient since this feature mostly cares about build reproducibility. Sadly I don't know a good way to test it since this feature is completely environment dependent, I'm happy to add such tests if anybody have an idea how to do it though.

runningcode commented 1 year ago

Thank you for the contribution!

runningcode commented 1 year ago

Sorry, I reverted this here: https://github.com/runningcode/gradle-doctor/pull/241

It doesn't work on my machine, see the revert for more details.