runningcode / gradle-doctor

The right prescription for your Gradle build.
http://runningcode.github.io/gradle-doctor
Apache License 2.0
722 stars 46 forks source link

Added support for zulu like jdks by performing the java home check based on bin(executables folder). #336

Closed slowpacer closed 2 months ago

slowpacer commented 2 months ago

Motivation for change - see this thread. Changes:

slowpacer commented 2 months ago

On the failing gitlab actions "MacOS check" job, feels a bit strange to be honest. Previous runs succeeded and obviously with the last change nothing new in terms of functionality wasn't introduced. Installed java 17.0.9 Temurin locally and ./gradlew pluginTasks builds successfully as well. Any recent changes in yml files or any configuration/dependencies change by chance? Maybe just flakiness? Anything I can help with(assuming I'm not allow to trigger the pipeline 🤣 )? @runningcode

runningcode commented 2 months ago

This is strange and seems unrelated to your work. I'm surprised this worked at all though because the build sets a JDK 8 toolchain but no JDK 8 is installed in the workflow.

runningcode commented 2 months ago

I pushed some commits to add JDK 8 to the workflows. That should help.

runningcode commented 2 months ago

Thank you very much!