Closed slowpacer closed 2 months ago
On the failing gitlab actions "MacOS check" job, feels a bit strange to be honest. Previous runs succeeded and obviously with the last change nothing new in terms of functionality wasn't introduced. Installed java 17.0.9 Temurin locally and ./gradlew pluginTasks
builds successfully as well. Any recent changes in yml
files or any configuration/dependencies change by chance? Maybe just flakiness? Anything I can help with(assuming I'm not allow to trigger the pipeline 🤣 )? @runningcode
This is strange and seems unrelated to your work. I'm surprised this worked at all though because the build sets a JDK 8 toolchain but no JDK 8 is installed in the workflow.
I pushed some commits to add JDK 8 to the workflows. That should help.
Thank you very much!
Motivation for change - see this thread. Changes:
JvmVariables
andJavaHomeCheckConfig
in order to use them as "injectable"JavaHomeCheck
constructor params, which slightly improves testability and decoupling.JavaHomeCheckPrescriptionsGenerator
and it's default implementation. Same reasoning - better testability and decoupling(nice to have a dedicated abstraction just to delegate the exact message generation).