Closed calvogenerico closed 3 years ago
Merging #11 (07bcf3d) into master (1f88cc2) will increase coverage by
0.39%
. The diff coverage is93.54%
.
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 80.98% 81.37% +0.39%
==========================================
Files 8 9 +1
Lines 957 988 +31
==========================================
+ Hits 775 804 +29
- Misses 182 184 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/bitcoin-node-connection.js | 93.10% <93.10%> (ø) |
|
src/config.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1f88cc2...07bcf3d. Read the comment docs.
Great work @hojarasca, and excellent tests. Now we have something available on testnet.
This PR adds an API implementation to directly connect run-db to a bitcoin node.
A few considerations:
rawtx
.zeromq
as optional dependecy. I used the optional dependency section because it has system dependencies and is not needed if you use any other api.axios
andzeromq
packages. I don't believe that those tests add a lot value.