Open runoutofit opened 1 year ago
Good point. Implementing this attribute, we have considered this possible flaw but have decided not to include it as we focused on functionality rather than on specifics for this iteration. Thus, rectifying it is less important. What was important to us at this point was ensuring only digits of specific lengths based on the international phone numbering convention was prioritized.
Since it does not affect the ability to make calls and that it keeps the full crucial information regarding a contact's phone record, we ensure that adding a +
would fail gracefully with the necessary error message indicating the crucial details required.
Team chose [response.NotInScope
]
Reason for disagreement: seeing that your app includes international phone numbers, it would lead to some confusion. for example, the following phone number 6561234567
could either be from Singapore or Tampa.
if you added the feature to add +
symbol, it would remove any ambiguity; if the above phone number is from Singapore i would've made the call without the 65
prefix.
it is common to use
+
for certain area code phone numbers, but this is not allowed in the app.