runoutofit / pe

0 stars 0 forks source link

does not allow special characters for phone number #6

Open runoutofit opened 1 year ago

runoutofit commented 1 year ago

image.png it is common to use + for certain area code phone numbers, but this is not allowed in the app.

soc-se-bot commented 1 year ago

Team's Response

Good point. Implementing this attribute, we have considered this possible flaw but have decided not to include it as we focused on functionality rather than on specifics for this iteration. Thus, rectifying it is less important. What was important to us at this point was ensuring only digits of specific lengths based on the international phone numbering convention was prioritized. Since it does not affect the ability to make calls and that it keeps the full crucial information regarding a contact's phone record, we ensure that adding a + would fail gracefully with the necessary error message indicating the crucial details required.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: seeing that your app includes international phone numbers, it would lead to some confusion. for example, the following phone number 6561234567 could either be from Singapore or Tampa.

https://wusfnews.wusf.usf.edu/economy-business/2022-01-13/the-tampa-bay-area-will-soon-have-a-new-656-area-code-and-10-digit-dialing

if you added the feature to add + symbol, it would remove any ambiguity; if the above phone number is from Singapore i would've made the call without the 65 prefix.