runpod-workers / worker-vllm

The RunPod worker template for serving our large language model endpoints. Powered by vLLM.
MIT License
222 stars 86 forks source link

Documentation incorrect regarding boolean #101

Open scriptcoded opened 3 weeks ago

scriptcoded commented 3 weeks ago

Hey!

Following the closing of #91 I noticed that the documentation still says that boolean environment variables can be substituted with 0 or 1. Looking at the environment variable parsing, this is not the case.

Suggested fix: Update the following comment to not mention the number format and instead that the parsing is case-insensitive.

+ > Note:  `0` is equivalent to `False` and `1` is equivalent to `True` for boolean as int values.
- > Note:  Boolean values are case insensitive. For example, `True` and `true` are equivalent.