runpod / runpodctl

🧰 | RunPod CLI for pod management
https://www.runpod.io/
GNU General Public License v3.0
246 stars 35 forks source link

Sending folders does not work on Windows #41

Open achanin00 opened 1 year ago

achanin00 commented 1 year ago

Instead of recreating the folder structure in the pod, runprodctl creates a bund of individual files with names like "

\" (notice that \ is not a folder seperator on linux).

The same functionality works fine when sending from linux. Does not work in Windows.

2023-06-13_18h21_45

Frederik-Frydenberg commented 1 year ago

Can confirm sending folders is broken on windows. I have to zip them first, then use runpodctl to send the zip. Else it loses all folder structure,

zlstringham commented 1 year ago

It fails on Windows due to packaging with \ in the path. There are also other idiosyncracies--- e.g. runpodctl send . creating a ..zip, and I think Windows can't receive folder from runpod.

.zip files explicitly forbid using \ in paths. See 4.4.17.1 of https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT

It's fixed in upstream dependency already: https://github.com/schollz/croc/pull/589