search

runthebusiness / puppet-eclipse

This class installs eclipse, eclipse plug ins and allows for management of projects and workspaces via puppet.
5 stars 5 forks source link

Parameters for archlinux, timeout for plugin installation, typos and linebreak issue. #5

Closed martinschulze closed 10 years ago

martinschulze commented 10 years ago

This runs correctly now. Setup is Windows 8 on host, Archlinux on guest.

runthebusiness commented 10 years ago

Hi Martin

Thank you very much for the contribution, I merged the pull request just now. I have a new branch I had done some work on but not merged yet which might have some similar fixes: https://github.com/runthebusiness/puppet-eclipse/tree/v1.1.0.b. My new branch is not tested yet however (been to swamped).

I will see if there is any overlap or our changes next week some time and add you to the contributors list.

Thanks again.

All the best.

Will Ferrer

On Wed, May 7, 2014 at 9:29 AM, Martin Schulze notifications@github.comwrote:

This runs correctly now. Setup is Windows 8 on host, Archlinux on guest.

You can merge this Pull Request by running

git pull https://github.com/martinschulze/puppet-eclipse master

Or view, comment on, or merge it at:

https://github.com/runthebusiness/puppet-eclipse/pull/5 Commit Summary

  • Correct the require parameters.
  • Add parameters for Archlinux.
  • Make the timeout of plugin installation adaptable.
  • Remove linebreak at plugin install template.

File Changes

  • M manifests/init.pphttps://github.com/runthebusiness/puppet-eclipse/pull/5/files#diff-0(8)
  • M manifests/params.pphttps://github.com/runthebusiness/puppet-eclipse/pull/5/files#diff-1(6)
  • M manifests/plugin.pphttps://github.com/runthebusiness/puppet-eclipse/pull/5/files#diff-2(5)
  • M templates/addplugins.erbhttps://github.com/runthebusiness/puppet-eclipse/pull/5/files#diff-3(2)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/runthebusiness/puppet-eclipse/pull/5 .

martinschulze commented 10 years ago

Hi Will,

i still have an issue with the eclipse.desktop file. If I don't manage to fix it I will open an issue here and ask for a chat. I am not that familiar with templates and it's hopefully easy to fix.

Thanks for your appreciation.

Martin

runthebusiness commented 10 years ago

Hi Martin

Sounds great. Feel free to take a look at my new branch as well to see if I already covered any of the issues. I added functionality for getting eclipse from a file instead of wget. Once again it is untested but at this point but might still be useful to check out. Also if it does look like it has something you need please feel to test it and if it works I will merge it into the the master branch.

I hope all is going great with you.

All the best.

Will Ferrer

On Wed, May 7, 2014 at 2:32 PM, Martin Schulze notifications@github.comwrote:

Hi Will,

i still have an issue with the eclipse.desktop file. If I don't manage to fix it I will open an issue here and ask for a chat. I am not that familiar with templates and it's hopefully easy to fix.

Thanks for your appreciation.

Martin

— Reply to this email directly or view it on GitHubhttps://github.com/runthebusiness/puppet-eclipse/pull/5#issuecomment-42485863 .