runtheops / ssm-diff

A human-friendly way of managing parameters in AWS SSM
MIT License
46 stars 25 forks source link

Integers defined break ssm-diff #9

Closed lanmalkieri closed 5 years ago

lanmalkieri commented 5 years ago

It appears that when you define an integer in SSM like

DEBUG_PORT: 80

This breaks ssm-diffs ability to initialize. Example of error output (I also added some print statements in to see where exactly the code was breaking).

NODE_ENV': production, u'TESTS_RUNNING': false, u'DEBUG_PORT': Traceback (most recent call last):
  File "/usr/local/bin/ssm-diff", line 80, in <module>
    args.func(args)
  File "/usr/local/bin/ssm-diff", line 9, in init
    print(r.get(flat=False, paths=args.path))
TypeError: __repr__ returned non-string (type int)

This essentially means that it is not possible to put any integer values into SSM. I can take a stab at fixing this but wanted to raise it as an issue first in the event you guys had a quick/easy fix.

lanmalkieri commented 5 years ago

Well this is odd, other integers work just fine.

 POSTGRES_PORT: 5432

This initializes without issue.

So after re-creating DEBUG_PORT: 80 as a variable in SSM from scratch, this all worked without issue.

There muse have been some weird case issue with the variable that got created the first time?

Either way I am closing this issue, it appears it was opened in earnest.