Upgrade node-ignore -> 3.x to solve several known issues.

runtimejs / runtime-cli

Command line tools for runtime.js

7 stars 5 forks source link

Upgrade node-ignore -> 3.x to solve several known issues. #2

Closed kaelzhang closed 8 years ago

kaelzhang commented 8 years ago

Upgrades node-ignore to the latest 3.0.11 to solve several known issues, including:

Files should not be re-included if the parent directory is ignored, #10
Works for windows, finally. #5
Better Handling with trailing whitespaces, wildcards of ignore patterns, according to gitignore spec, and passed all cases described in the spec.

However, it is a pity that there is no existing test cases about '.runtimeignore'.

iefserge commented 8 years ago

@kaelzhang This looks great! Thank you for a great library! Yep, I agree tests could have been better for this.

Not really related to this PR, one thing I noticed that patterns like this

/*
/*/
!/js/

should ignore everything except /js directory, but instead everything is ignored.

kaelzhang commented 8 years ago

Maybe it was an issue of the old node-ignore. I have tested the case you provided just now, and it works.

The patterns will ignore everything except the FILES inside /js directory, NOT except the /js directory itself. Git doesn't track an empty directory.