Closed facekapow closed 8 years ago
Goodbye commit history :)
Also added guidelines for contributing, plus a list of exceptions to Airbnb's style guide.
How do we update runtime with npm.
This is done and ready for review/merge, the only thing I'm not really confident about is the CONTRIBUTING.md
. I've got some more node compatibility fixes, but I'd prefer to add them in another PR after this has been merged to avoid any conflicts.
This is awesome, I'll do some tests too, to make sure everything works.
Ok, I've update the code to only use arrow functions for property functions and callbacks and function declarations for everything else, I've run the code through a beautifier, removed the newlines in js/__loader.js
, used spaces instead of newlines in js/core/pci/scan.js
, readded eslint-plugin-runtime-internal
, disabled no-use-before-define
for functions, and fixed the other issues you mentioned.
And I tested it and it still works.
Converted IIFE functions to arrow functions, and fixed the minor style issues. Sorry, most of these little things are because of the beautifier I ran it through.
@facekapow left couple of places where there are a few statements on the single line.
@iefserge Well, that's the last time I use a beautifier 😄
LGTM great work 👍
wow. Amazing.
Great, then I'll just do a quick once-over on the code and merge.
Everything looks ok, I tried to run the JS tests, but those are definitely broken (more specifically, tape
kept complaining about Stream
), but I did some manual feature testing and everything looks fine. Merge?
bye-bye history of changes :)
@facekapow yeah, I've been looking into tests issue, should be fine, going to fix it afterwards. @vitkarpov yeah, but consistent and nice code style is good :)
This PR is a big one, it changes pretty much all of the JavaScript files, since it updates everything to ES6, plus adopts airbnb/javascript as a code style (with a few tweaks, like using require instead of ES6 modules).
Done so far:
js/*.js
js/component
js/component/dns-client
js/core
js/core/*.js
js/core/debug
js/core/keyboard
js/core/net
js/core/pci
js/core/ps2
js/core/random
js/core/stdio
js/core/tty
js/driver
js/driver/ps2
js/driver/virtio
js/driver/virtio/vring
js/driver/virtio/*.js
js/modules
js/service
js/service/dhcp-client
js/service/dns-resolver
js/service/shell
js/test
js/test/unit
js/test/unit/buffers
js/test/unit/lib
js/test/unit/net
js/test/unit/platform
js/test/unit/random
js/test/unit/script
js/test/unit/timers
js/test/unit/virtio
js/utils