search

runtimejs / runtime

[not maintained] Lightweight JavaScript library operating system for the cloud
http://runtimejs.org
Apache License 2.0
1.93k stars 128 forks source link

V8 5.4.9 #124

Closed iefserge closed 7 years ago

piranna commented 8 years ago

Why instead of bundle a copy of v8 in the source tree it's not downloaded from upstream on an initial step as NodeOS generator does? Is it being applied some patch to the v8 code? If so, why not apply it instead on download step, too? El 9/7/2016 11:14, "Serge" notifications@github.com escribió:

You can view, comment on, or merge this pull request online at:

https://github.com/runtimejs/runtime/pull/124 Commit Summary

  • Squashed 'deps/v8/' changes from f9d096c..7560bab
  • Resolve conflicts
  • V8 libs and snapshot
  • Update V8 5.4.9

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/runtimejs/runtime/pull/124, or mute the thread https://github.com/notifications/unsubscribe/AAgfviTaX6yBsTnoapzI7fgxygZomU50ks5qT2aTgaJpZM4JIlPH .

iefserge commented 8 years ago

@piranna Few reasons, of course there are possibilities for improvement:

piranna commented 8 years ago

Definitely that complicate things and would make build process slower... :-/ El 9/7/2016 12:02, "Serge" notifications@github.com escribió:

@piranna https://github.com/piranna Few reasons, of course there are possibilities for improvement:

  • yeah, v8 is patched a bit, things that deal with OS APIs. This can be improved by directly supporting functions like gettimeofday etc.
  • v8 build system creates some generated files, converts js files into c++ byte arrays. This would require running v8 build system once.
  • Snapshot needs to be generated for faster startup, this requires running QEMU once.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/runtimejs/runtime/pull/124#issuecomment-231526661, or mute the thread https://github.com/notifications/unsubscribe/AAgfvumrmVB9HPkai59cXIm4JCgLc09_ks5qT3G4gaJpZM4JIlPH .

piranna commented 7 years ago

Just a suggestion for the future: since v8 needs to be included because there are some parts that need to be autogenerated, why not host this autogenerated v8 on another repo and just download it? This would make more clear runtime.js repo, and v8 one could be auto-updated itself... This is what I'm currently doing with NodeOS, to make a mechanism to keep auto-updated all the external dependencies... El 16/7/2016 21:24, "Serge" notifications@github.com escribió:

Merged #124 https://github.com/runtimejs/runtime/pull/124.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/runtimejs/runtime/pull/124#event-725272311, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgfvkTPL1b6uqiY5-OJcJif02qASZlJks5qWS_3gaJpZM4JIlPH .