runtimejs / runtime

[not maintained] Lightweight JavaScript library operating system for the cloud
http://runtimejs.org
Apache License 2.0
1.93k stars 128 forks source link

Modifier keys #49

Closed facekapow closed 9 years ago

facekapow commented 9 years ago

Currently, the terminal input listens for keydown, which is fine, for now. But, for CTRL+C (and etc) to work, the terminal input should listen for keyup. It would require no change in input processing, just a change in listeners (unless you decide to implement modifiers). This is not a current issue, but could be in the future.

iefserge commented 9 years ago

@ArielAbreu There is a keyboard object that emits raw keyup/keydown events that include modifier keys as well. Shell could use this to implement CTRL+C feature. https://github.com/runtimejs/runtime/blob/master/js/core/keyboard/index.js