search

runtimejs / runtime

[not maintained] Lightweight JavaScript library operating system for the cloud
http://runtimejs.org
Apache License 2.0
1.93k stars 127 forks source link

Remove builtin commands #64

Closed facekapow closed 9 years ago

facekapow commented 9 years ago

Remove builtins from runtimejs, since I added more commands in an optional module called runtime-shell. I've already opened this PR before, but, I accidentally deleted the branch, so... I recreated it and opened it again.

iefserge commented 9 years ago

@ArielAbreu I think it's a good idea to move commands out of core to runtime-shell, except maybe reboot/poweroff because they're very system dependent.

iefserge commented 9 years ago

Like echo and clear are part of a shell for sure.

facekapow commented 9 years ago

I'll redo the PR because it I accidentally deleted the repository.

piranna commented 9 years ago

except maybe reboot/poweroff because they're very system dependent

I would move them too, and only allow them as an API.

facekapow commented 9 years ago

I agree with @piranna, anything that is added for convenience can (not must) be moved out into a module.

iefserge commented 9 years ago

@piranna hm, I use them very frequently when debugging runtime in KVM in curses mode, however I don't need full shell for that

iefserge commented 9 years ago

(I can remotely ssh to linux machine and run runtime in KVM without graphical interface)

facekapow commented 9 years ago

I've been working on a telnet server (since I have Mac, which means no KVM) for runtime which listens on port 9000 (the forwarded port) which can be used for more direct remote control. That aside, if shutdown and poweroff are going to be the only commands, maybe they could be moved into index.js with command 1.

iefserge commented 9 years ago

@ArielAbreu sounds good, let's do this

facekapow commented 9 years ago

Opened #69.