search

runtimerevolution / survey

Survey is a Rails Engine that brings quizzes, surveys and contests into your Rails application.
MIT License
265 stars 127 forks source link

Rails 5 Support #43

Open 3zcurdia opened 7 years ago

3zcurdia commented 7 years ago

What is the reason to not support to Rails 5 in the latest version?https://github.com/runtimerevolution/survey/blob/master/survey.gemspec#L14

If there is no reason, shall we include it in the next release

emersonthis commented 7 years ago

I'd love to use this in a Rails 5 app also! Any news on whether this is on the horizon?

pedroadame commented 7 years ago

+1

grimmwerks commented 7 years ago

Any additional info - is it ready?

tycoool commented 6 years ago

+1

osimakoff commented 5 years ago

Any word on this? Thanks!

natsandovalt commented 5 years ago

Any news?

eriko-de commented 4 years ago

I prepared a commit, feel free to review (haven't done much on github yet, so please be patient with noobish mistakes)

bjacquet commented 4 years ago

I opened a PR to support this.

@eriko-de we both worked on this at the same time!

I was having a hard time keeping both Rails versions (3.2.6 and 5.0.7) because of Bundler incompatibility. I.e. Rails 3 uses Bundler 1 and Rails 5 uses Bundler 2, and Bundler 1 isn't compatible with 2 (and vice-versa). For this reason I gave up on Rails 3. It's Rails 5 from now on. 🚀

eriko-de commented 4 years ago

I had no issue using bundler with ruby < 2.5 (used 2.3). i also don't get why it should be incompatible. nevertheless i did not had time to fully test the gem in a rails 3.x embedded app, but in our rails 4.x app all is working as expected after including the gem.

Don't understand why the dependency should be pushed from 3 to 5 not supporting 3 and 4 at all. I think this would introduce a lot of issues for other users.

bjacquet commented 4 years ago

I first tried to keep the dependency from 3 to 5. But doing so I could not create an app for Rails 5 and another for Rails 3, using the same version of the gem. Maybe my system is not well configured or maybe I don't fully grasp RVM and Bundler and so.

The Rails version on my PR (5.0.7) is itself an unmaintained version. 5.2 is the oldest still with maintenance. Current users of the gem that do not want or do not need to upgrade to Rails 5 will have to lock this gem version in their Gemfile.

Either way, future developments will surely break retro-compatibility. The moment we use some new feature from Rails 6 or Ruby 3 our support for older gem versions is gone.

May I suggest you @eriko-de try to look into our PRs and try to create a gem supporting 3 through 5. See if you can create an app in Rails 3, 4, and 5. If you can, then great! 🎉 Meaning it's definitely my fault not being able to do so in the first place.

eriko-de commented 4 years ago

Hey, sorry for the silence. I used my patch to get the gem working for our software (Rails 4, Ruby 2.3.3). It's running fine in our test environment, but we'll also update to Rails 5 at the end of the month (hopefully).

After updating to Rails 5, we would like to stick to the original repo again. So i'm happy with any PR which gets merged to get it running on Rails 5.

I wasn't able to get rails 3 running in the test suit because the dependencies are quit painful. I don't want to waste too much time, because, as you mentioned, it is rails 5 time :)