search

runtimeverification / llvm-backend

KORE to llvm translation
BSD 3-Clause "New" or "Revised" License
34 stars 19 forks source link

Using `map` instead of `unordered_map` to ensure reproducibility of kore definition generation #1059

Closed Robertorosmaninho closed 1 month ago

Robertorosmaninho commented 1 month ago

We have seen that the definition.kore has been produced in a different order depending on the OS, which creates a flaky error for some tools like llvm-komplie-compute-ordinal and llvm-kompile-compute-loc, an error on #1053 MacOS tests, and some frontend errors as well.

This PR aims to fix that issue by replacing the data structure used to store the attributes.

Baltoli commented 1 month ago

Will need formatting to fix CI but otherwise looks good!