The Math Proof Team has had an issue with llvm_rewrite_trace_iterator where they start iteration in one function, and finish in another function, passing the iterator as an argument to this second function. This second function also generates an Iterable object that is then returned in the first function.
This complex workflow was raising a Python Segmentation Fault on the call of get_next_event inside our class LLVMRewriteTraceIterator. After many hours of debugging, I reached a point where I discovered that the arities_ of the kore_header object were corrupted, and then the parser threw a Segmentation Fault when trying to execute get_arity.
I believe the Pybind deleted the kore_header object when the function finishes, as it was the only const ref on the function, and then when we tried to access it lazily using the Iterable object created by the MPG team, the memory where kore_header lived was already freed.
By making it a shared_ptr, we ensure it's only deleted when the whole object is deleted, sharing the ownership of it with the C++ code.
The Math Proof Team has had an issue with
llvm_rewrite_trace_iteratorwhere they start iteration in one function, and finish in another function, passing the iterator as an argument to this second function. This second function also generates an Iterable object that is then returned in the first function.This complex workflow was raising a
Python Segmentation Faulton the call ofget_next_eventinside ourclass LLVMRewriteTraceIterator. After many hours of debugging, I reached a point where I discovered that thearities_of thekore_headerobject were corrupted, and then the parser threw a Segmentation Fault when trying to executeget_arity.I believe the Pybind deleted the
kore_headerobject when the function finishes, as it was the only const ref on the function, and then when we tried to access it lazily using the Iterable object created by the MPG team, the memory where kore_header lived was already freed.By making it a
shared_ptr, we ensure it's only deleted when the whole object is deleted, sharing the ownership of it with the C++ code.