dkcumming
commented
12 months ago I had the test runner send the completed process of the above test to a file:
args=[
'/tmp/pytest-of-daniel/pytest-51/popen-gw3/kbuild0/v6.0.145/llvm/parser_Mir_MIR-SYNTAX',
'/tmp/pytest-of-daniel/pytest-51/popen-gw3/test_compiletest_compiletest_r1/preprocessed.mir'
],
returncode=0,
stdout=
//--snip--
inj{SortAssign{}, SortStatementKind{}}(
Lbl\'UndsEqlsUndsUnds\'MIR-STATEMENT-SYNTAX\'Unds\'Assign\'Unds\'Place\'Unds\'RValue{}(
inj{SortLocalToken{}, SortPlace{}}(
\\dv{SortLocalToken{}}(
"_19"
)
),
Lblamb{SortRValue{}}(
inj{SortAddressOf{}, SortRValue{}}(
Lbl\'And-UndsUndsUnds\'MIR-RVALUE-SYNTAX\'Unds\'AddressOf\'Unds\'PtrModifiers\'Unds\'Place{}(
Lbl\'Unds\'MIR-RVALUE-SYNTAX\'Unds\'PtrModifiers{}(),inj{SortLocalToken{}, SortPlace{}}(
\\dv{SortLocalToken{}}(
"_20"
)
)
)
),
inj{SortRef{}, SortRValue{}}(
Lbl\'And-UndsUnds\'MIR-TYPE-SYNTAX\'Unds\'Ref\'Unds\'TypeNoBounds{}(
inj{SortTypePathEndSegment{}, SortTypeNoBounds{}}(
Lbl\'UndsUndsUnds\'MIR-TYPE-SYNTAX\'Unds\'TypePathEndSegment\'Unds\'PathIdentSegment\'Unds\'PathIdentSegmentEndSuffix{}(
inj{SortLocalToken{}, SortPathIdentSegment{}}(
\\dv{SortLocalToken{}}(
"_20"
)
),inj{SortPathIdentSegmentSuffix{}, SortPathIdentSegmentEndSuffix{}}(
Lbl\'Unds\'MIR-TYPE-SYNTAX\'Unds\'PathIdentSegmentSuffix{}()
)
)
)
)
)
)
)
)
//--snip--In particular ... Lblamb{ ... is described in this documentation on ambiguous languages.
Likely the difference stems from a fork in the production of the parsers. Investigation confirmed that this branch is not taken with poetry run kmir parse ... however the test runner does take the branch.
yanliu18
mariaKt
Problem
The
pytestrunner appears to classify ambiguous parses as passing. Running a test with a parsing ambiguity directly will create the expected[Error] Inner Parser: Parsing ambiguity.error. Howevermake compiletest-parse-failwill not filter this test intocompiletest-parse-fail.tsv, andmake test-integration-parsewill pass the test.Solution
Find and fix issue in test runner and re-run tests