search

runtimeverification / mpfr-java

GNU MPFR Java Bindings
Other
11 stars 10 forks source link

First draft of BigFloat package #1

Closed dwightguth closed 10 years ago

dwightguth commented 10 years ago

@andreistefanescu please review everything, not just the diff of this pull request (which excludes the initial commit)

cos commented 10 years ago

I had a look over the pull request. It looks good at a high level but I have no experience with JNI so I cannot assess that part well. Is there anybody who played with JNI before?

cos commented 10 years ago

Regarding maven, I think the current way is ok until we figure out a group-wide solution to dependency management.

andreistefanescu commented 10 years ago

Overall, it looks good. I did not check all the details thought, so there may be small things I missed.

dwightguth commented 10 years ago

@cos if you are happy with my changes/comments, let me know and I will merge this.

cos commented 10 years ago

aside from the minor issue above, it looks good to me