search

runtimeverification / rv-predict

Code for improved rv-predict and installer
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

more detailed race report? #183

Closed yilongli closed 9 years ago

yilongli commented 9 years ago

Here is a typical race report generated by threadsanitizer: https://code.google.com/p/data-race-test/wiki/UnderstandingThreadSanitizerReports

Do we want something similar? Right now, I am not sure how hard it is to implement because I haven't started look into the prediction part of the code. But I should be able to tell in a few days.

What do you think? @grosu @traiansf @jeffhuanguiuc

traiansf commented 9 years ago

It looks nice, in not almost impressive. I think some, if not most of it could be recoverable from the schedule (if we generate it).

I start to see @grosu 's point of splitting the tool into the prediction algorithm, which we should be experts at, and the interface, which could be standardized.

grosu commented 9 years ago

1) These guys are experts.

2) Their tool has been used by hundreds, if not thousands of people (Yilong, do you think you can point me to the team behind Thread sanitizer, so I get in touch with them and maybe get some data-base of users?).

3) Users are already familiar with that that kind of output.

So, unless we have something which is obviously better by a large margin, we should be complete egomaniac morons to not follow their model.

Just my 2 cents :)

Grigore

From: Traian Florin Șerbănuță [notifications@github.com] Sent: Wednesday, November 12, 2014 7:00 AM To: runtimeverification/rv-predict Cc: Rosu, Grigore Subject: Re: [rv-predict] more detailed race report? (#183)

It looks nice, in not almost impressive. I think some, if not most of it could be recoverable from the schedule (if we generate it).

I start to see @grosuhttps://github.com/grosu 's point of splitting the tool into the prediction algorithm, which we should be experts at, and the intreface, which could be sandardized.

— Reply to this email directly or view it on GitHubhttps://github.com/runtimeverification/rv-predict/issues/183#issuecomment-62714205.

yilongli commented 9 years ago

Yes. Threadsanitizer has been integrated to LLVM and GCC as an option, so their users are unlimited:)

The most important guy behind Threadsanitizer is Konstantin Serebryany: http://research.google.com/pubs/KonstantinSerebryany.html. Co-authors in this page are also major contributors.

yilongli commented 9 years ago

BTW, here is an interesting article about the use of threadsanitizer in google: http://googletesting.blogspot.com/2014/06/threadsanitizer-slaughtering-data-races.html

traiansf commented 9 years ago

I wonder why internet provider blocks this url due to "Parental Control" restrictions. Maybe they don't like "slaughtering", not even data races...

2014-11-12 18:07 GMT+02:00 Yilong Li notifications@github.com:

BTW, here is an interesting article about the use of threadsanitizer in google: http://googletesting.blogspot.com/2014/06/threadsanitizer-slaughtering-data-races.html

— Reply to this email directly or view it on GitHub https://github.com/runtimeverification/rv-predict/issues/183#issuecomment-62742775 .

yilongli commented 9 years ago

Fixed via https://github.com/runtimeverification/rv-predict/pull/334