Changes when adding strings and images

runway20 / PopoverView

A simple UIView popover control for iPhone/iPad written in CoreGraphics.

1.02k stars 213 forks source link

Closed jallen closed 11 years ago

jallen commented 11 years ago

First off, very cool control. Thanks for putting it out there.

I made a few changes when adding strings and images to a PopoverView and thought others might be interested.

Changes:

kImageAboveLabel - bool value that positions icons/images above or to the left of labels
kImageTitlePadding - padding between icons/images and titles in both horizontal and vertical
UIButtons generated for both horizontal and vertical settings

ocrickard commented 11 years ago

This is awesome work. I'm going to try and test/merge this tomorrow!

ocrickard commented 11 years ago

Sorry for the delay. Things got crazy around here.

I can't merge this yet:

If you would like to change the styling, that's totally your choice, but I can't merge large changes to the styling into the main branch.
It would appear the the PopoverView.m file has an incomplete implementation. Specifically, this method has no implementation:

- (NSMutableArray *)_makeTempViewsWithStrings:(NSArray *)stringArray andImages:(NSArray *)imageArray;