Changes when adding strings and images

runway20 / PopoverView

A simple UIView popover control for iPhone/iPad written in CoreGraphics.

1.02k stars 214 forks source link

Changes when adding strings and images #22

Open jallen opened 11 years ago

jallen commented 11 years ago

I took another stab at this by creating a branch instead of using my forked master (git noob here). I also found a weird bug that was causing buttons with just text in a titled Popover to be resized past the width of the popover. Take a look at commit bfe1db9 for more info.

Changes:

kImageAboveLabel - bool value that positions icons/images above or to the left of labels
kImageTitlePadding - padding between icons/images and titles in both horizontal and vertical
UIButtons generated for both horizontal and vertical settings

ocrickard commented 11 years ago

Hey man, sorry for the long wait! I suck at responding to these...

Since there have been a couple of changes since you submitted this, I just merged by hand. Mind giving it a sanity check before I merge into master?

https://github.com/runway20/PopoverView/tree/jallen-buttons-with-icons

jallen commented 11 years ago

This works if you just want an images above labels. It not using the image as part of a UIButton so you don't get the nice over effect with the tap.

And it's also missing support for kImageAboveLabel in the config file so images can be rendered to the left of the label.

If you want and can rebase and create a new pull request with the latest master.

It's up to you.