stewartshea
commented
1 year ago No specific reason. Didn't try it any other way. Is there a reason it should be there? Seems like it might be easier to debug if it has its own task. E.g. if it fails, you have to go through the whole setup logs to sort that out?
-- Shea Stewart (he/him) c:647-972-5191 @.*** Book a meeting https://calendly.com/stewartshea
On Thu, Mar 30, 2023, 12:30 p.m. jon-funk @.***> wrote:
@.**** commented on this pull request.
In codebundles/mongodb-health-gcp-promql/sli.robot https://github.com/runwhen-contrib/rw-public-codecollection/pull/103#discussion_r1153502331 :
@@ -0,0 +1,193 @@ + Settings +Metadata Author Shea Stewart +Documentation Uses promql on the Ops Suite API to determine the health of a MongoDB database instance +... and pushes the result as an SLI metric. Produces a 1 for a healthy resource, or 0 for an unhealthy resource. +Force Tags GCP OpsSuite PromQL MongoDB +Library RW.GCP.OpsSuite +Library RW.Core +Library RW.Utils +Library RW.Prometheus +Library String +Library Collections +Suite Setup Suite Initialization + + Tasks +Get Access Token
Interesting that you made this its own task instead of in the initialization. Why's that?
— Reply to this email directly, view it on GitHub https://github.com/runwhen-contrib/rw-public-codecollection/pull/103#pullrequestreview-1365492561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELXHOFL4LP24J6VKTB5FP3W6WYKJANCNFSM6AAAAAAWMEUTGY . You are receiving this because you authored the thread.Message ID: <runwhen-contrib/rw-public-codecollection/pull/103/review/1365492561@ github.com>
Adds the composite SLI healthcheck for mongodb with promql (GMP). Also added a couple of touchups to the kong codebundle, mostly cosmetic. Also adds min/max to json metric keyword.