Geo graph browser events.

runziggurat / ziggurat-viz

The Ziggurat Visualizations.

https://app.runziggurat.com

1 stars 0 forks source link

Geo graph browser events. #36

Closed muzam1l closed 1 year ago

muzam1l commented 1 year ago

Adds touch input support to allow sliding of map just like mouse-drag.
Adds Zoom gestures ie. trackpad pinch and touch-input pinch to the map. This is in addition to the mouse wheel zooming.
Bunch of refactoring related to browser events handling of the map.

What this doesn't cover and is left for later PR's:

Zooming curve: some ease-out style animation for smoother zoom across all gestures.
Touch clicking: currently, you can hardly select a node on the map using touch as it behaves similarly to a mouse click. It needs some optimizations to select the most suitable adjacent node on touch.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zcash-gui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2023 4:02pm

zeapoz commented 1 year ago

This is cool! I can't speak much for the touch part of this PR, but some thoughts on the trackpad part:

When zooming using the pinch motion it appears to be very choppy compared to the standard zoom.
The pinch motion is also noticeably slower than the alternative.

What this doesn't cover and is left for later PR's:

Zooming curve: some ease-out style animation for smoother zoom across all gestures.

This sounds like a good improvement! It's a bit counterintuitive to always lerp with the same timescale/speed, always felt a bit clunky :smile:

muzam1l commented 1 year ago

To focus on this pr issue only, see #37, which might affect performance. Page refresh is recommended for now.

muzam1l commented 1 year ago

Is it any better now @zeapoz? Don't forget to refresh the page first due to the above-mentioned issue! We can increase the magnitude of the trackpad pinch further if needed.

zeapoz commented 1 year ago

Is it any better now @zeapoz? Don't forget to refresh the page first due to the above-mentioned issue! We can increase the magnitude of the trackpad pinch further if needed.

I think we should be good to double the current pinch travel from what it is now. Also, ctrl doesn't seem to impact the travel distance, like the code would suggest.

muzam1l commented 1 year ago

I think we should be good to double the current pinch travel from what it is now.

Made it 2x of what it was. The zoom curve is weird in general, so will fix it later, but right now let's make it equal to wheel zoom.

Also, ctrl doesn't seem to impact the travel distance, like the code would suggest.

It only affects the mouse wheel zoom (plus trackpad two-finger swipe-up zoom, wherever enabled). It's a bit of trickery to detect the trackpad pinch. In that case, the browser emits the same wheel event with ctrl enabled, whether or not your press it 🫠.