Open yangbo opened 8 months ago
A good question that I'll need to get into the code to debug why.
As you can tell I haven't been active here much, but there seem to be some small bugs popping up that I need to fix/improve. I'll have a look this weekend.
Also, please feel free to make a PR from your fork, I appreciate your contributions and code contributions 🙇 🙏
Thanks for your reply.
I have added some features in my fork of this project.
They are:
I will try to make a PR, if there are something wrong, please tell me. : )
Cheers!
Hi ruohoruotsi, Thanks for your work on this library.
I found the Butterworth class's output a1 and a2 of SOS are awayls change sign compare to matlab results. Such as if c++ output a1=0.1,a2=-0.2 then matlab's a1=-0.1, a2=0.2.
Is there something that I missing? If the output of Butterworth.bandPass() gives digital filter Biquad coefficients then is it should be the same as matlab's results?
Thanks for your help.
C++ Test code like below:
Matlab test code like:
Then you can see
coeffs[i].a1 == -bsos[i+1, 5]
andcoeffs[i].a2 == -bsos[i+1, 6]
. i from 0 to length of coeffs.