ruotianluo / self-critical.pytorch

Unofficial pytorch implementation for Self-critical Sequence Training for Image Captioning. and others.
MIT License
991 stars 278 forks source link

An error occurs when num_images > it_max #247

Open blalalt opened 3 years ago

blalalt commented 3 years ago

https://github.com/ruotianluo/self-critical.pytorch/blob/58b4ea9f77a6b53a1d22138e6502fd4471e5b429/captioning/utils/eval_utils.py#L207

        # num_images =  5000, it_max = 500
        ix1 = data['bounds']['it_max']
        if num_images != -1:
            ix1 = min(ix1, num_images) # should be `num_images = min(ix1, num_images)` ??
        else:
            num_images = ix1
        for i in range(n - ix1):
            predictions.pop() # error, pop from empty list
        # .......
        if num_images >= 0 and n >= num_images: # until `n == 5000`
            break