Error message is not specific to error made in delete and edit command (invalid index error message)

[ruoyann]

The error message displayed when user tries to delete a goal out of the current index range:

Similarly when user tries to delete a very large index

The error messages for the above two invalid commands should be exactly the same. And that is "The specified index is invalid" because the second invalid input is in fact using the correct format.

This applies to the other commands that uses index as well (e.g. edit command, delete in todo)

[nus-pe-bot]

Team's Response

1. The first screenshot shows the error message for an expected wrong input (of a reasonable but non-existent index), whereas the second screenshot shows the error message when there is integer overflow, i.e. the index is greater than Integer.MAX_VALUE. The use case exemplified in the second screenshot is arguably a case of intentional sabotage because:

• Integer.MAX_VALUE is a very large number, in the billions, as seen from the javadocs page for Integer.
• This means that the user would need to "accidentally type" more than 9-digits long in order for such behaviour to be observed
• It is highly implausible that the user types in such a long index purely on accident during normal use.
• Furthermore, it is highly implausible that the user would have so many entries in any of the lists that the indices they need to specify get even remotely close to that magnitude.

2. Even so, the error messages have essentially the same meaning, and get the same point across to the user. Hence the user's usage of the app is not hindered. Hence, this inconsistency is a mere cosmetic issue and should only be of veryLow severity, if it were to count as a legitimate bug and not intentional sabotage.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: Prof's example for intentional sabotage is entering a 30 digit phone number, which can never exist.

However when using this app, users may have a large amount of information, especially under schedule if they have recurring events. I still believe the team should consider large numbers, or at least specify in the UG about limitations of the app (currently not stated). Hence I still think this should be at least a veryLow severity bug.

---

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---