rupa / z

z - jump around
Do What The F*ck You Want To Public License
16.37k stars 1.17k forks source link

Fix -e option (fixes #239) #242

Closed ruduran closed 6 years ago

ruduran commented 6 years ago

This commit fixes the -e option which was failing as described on #239.

Just assign 1 to $echo, just like with the -l option.

rupa commented 6 years ago

what shell is this a problem with. i'm not opposed to the change cause the value of $echo is just being used as a boolean nowadays, but what are you using that thinks "echo" is falsey?

rupa commented 6 years ago

oh huh maybe its from echo=echo instead of echo="$echo" i could see that being a problem for something...

ruduran commented 6 years ago

Yup, that's it, and since the usage is the same with list I thought it would be a good idea to do the same and just assign 1.

politicus commented 5 years ago

As I couldn't make the -e option work when installed with Homebrew, I installed z via a git clone. And the -e option finally worked as expected.