search

rupadana / filament-api-service

A simple api service for supporting filamentphp
https://filamentphp.com/plugins/rupadana-api-service
MIT License
95 stars 22 forks source link

add Laravel 11 support #21

Closed atmonshi closed 3 months ago

atmonshi commented 4 months ago

need to do more testing since sanctum updated to v4 and not sure if it will affect the pacakge! https://laravel.com/docs/master/upgrade#sanctum

faizananwerali commented 3 months ago

Laravel 11 has been released. Now waiting for this pull request to get approved.

faizananwerali commented 3 months ago

I have tested and it is working fine with Laravel 11 and Sanctum.

atmonshi commented 3 months ago

I have tested and it is working fine with Laravel 11 and Sanctum.

prefect, no extra changes required? I marked this PR ready :)

faizananwerali commented 3 months ago

I have tested and it is working fine with Laravel 11 and Sanctum.

prefect, no extra changes required? I marked this PR ready :)

Yes no extra changes required

rupadana commented 3 months ago

Thank you for your contribution @atmonshi @faizananwerali,

We can merge it after the test pase is successfully passed. There are error while running test, can you please update it?

atmonshi commented 3 months ago

all good now, hope I didnt forget anything if you can run the tests and let see :)

rupadana commented 3 months ago

all good now, hope I didnt forget anything if you can run the tests and let see :)

hmmm its like the migration isn't executed

atmonshi commented 3 months ago

I dont know what happened there , but I hope this time it will work :) btw you have access to edit anything in this pr :)

rupadana commented 3 months ago

Finally, its merged. Thank you for your contribution guys @atmonshi @faizananwerali. Appreciate it ☺️