Open GabrielBittar opened 3 weeks ago
As per contributing guidelines, you can only work on 1 issue at a time.
Hello GabrielBittar! Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊
Please make sure to follow our Contributing Guidelines. 💪🏻
Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed. Our review team will carefully assess the issue and reach out to you soon! 😇 We appreciate your patience!
I am up for this change
@GabrielBittar i think its gonna be a good practice. What about the links who don't have any category? are we going create new category and subcategory?
@GabrielBittar i think its gonna be a good practice. What about the links who don't have any category? are we going create new category and subcategory?
Yes, this seems to be the best approach, creating the new cats/subs in those cases. Since the issue looks alright, I intend to start working on this as soon as assigned.
@rupali-codes Please assign him if it's okay. This would be useful imo.
@GabrielBittar you're assigned.
@GabrielBittar you're assigned.
Ok! Thanks, I'll start working on it.
During work, found the seemingly unused DSA
folder with DSAYouTube.json
. Also found Resources > dsa.json
. Total of 3 links. I took the liberty to send these links to data_structures > dsa_tutorials
and data_structures > dsa_articles
, since there is ady this category for them. I'm communicating since this is not part of the discussed issue, so if you guys think this should not be done, please alert me so I don't send these changes.
During work, found the seemingly unused
DSA
folder withDSAYouTube.json
. Also foundResources > dsa.json
. Total of 3 links. I took the liberty to send these links todata_structures > dsa_tutorials
anddata_structures > dsa_articles
, since there is ady this category for them. I'm communicating since this is not part of the discussed issue, so if you guys think this should not be done, please alert me so I don't send these changes.
Put them together in the same category but create different subcategory as mentioned :)
Are you done @GabrielBittar ?
I am for this task tho.
Are you done @GabrielBittar ?
No, I'm working on it.
Oh no problem
On Fri, 6 Sept, 2024, 11:00 pm GabrielBittar, @.***> wrote:
Are you done @GabrielBittar https://github.com/GabrielBittar ?
No, I'm working on it.
— Reply to this email directly, view it on GitHub https://github.com/rupali-codes/LinksHub/issues/2474#issuecomment-2334516838, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP333TAVZMWVNQGKWXYJQILZVHRE3AVCNFSM6AAAAABMW6PJUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGUYTMOBTHA . You are receiving this because you commented.Message ID: @.***>
File Name
/database/youtube
Reason for Refactoring the Code
Changes proposed
Maybe we can think about dissolving
Youtube
Category, moving each of its links to the categories that fit each subject of each link that is in there.Reason
Users will most probably search content based on their interest subjects, like "design" or "frontend"... And Ytb is not a subject, it is one of the platforms from which we are taking content to insert inside those subjects.
Example
See
Languages > C Programming > CodeWithHarry
. This link seems to be in the right place, though it doesn't, at the same time. It is a ytb link, so it could be insideYoutube > WebDevelopment
as well and it would not be wrong. There are plenty of other cases that could illustrate this problem. It seems to me youtube channels should be all just likeCodeWithHarry
, in its repective section, and none inside aYoutube
category.I'm interested in working on it, if this change seems plausible.
Checklist