search

rupert / pyls-black

Black plugin for the Python Language Server
MIT License
72 stars 8 forks source link

Added support for skip-numeric-underscore-normalization #6

Closed dbarrosop closed 5 years ago

pmiddend commented 5 years ago

Note that you have a "line too long" error there.

dbarrosop commented 5 years ago

where? all the checks are green

pmiddend commented 5 years ago

Maybe I misread the output:

https://circleci.com/gh/rupert/pyls-black/42

dbarrosop commented 5 years ago

Oh, that's an old build. Last one is:

https://circleci.com/gh/rupert/pyls-black/47

wy-z commented 5 years ago

image

I need this patch. Thank you for your contribution @dbarrosop

kodonnell commented 5 years ago

@rupert is there a way to get this reviewed (and hence merged)? Also, a new push to pypi?

rupert commented 5 years ago

@dbarrosop thanks for the PR! I will have a look this evening 👍

Mic92 commented 5 years ago

Tested successfully.

Mic92 commented 5 years ago

it would make sense to also create a release when merging this. I will then update the nixpkgs package accordingly: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pyls-black/default.nix

rupert commented 5 years ago

@dbarrosop thanks again and sorry for the delay - this is released in version 0.3.0.

dbarrosop commented 5 years ago

Awesome! Thanks!