search

rupl / bustashape

Collaborative, real-time artboards
https://bustashape.art
MIT License
5 stars 3 forks source link

Fix security vulnerabilities #72

Closed rupl closed 8 years ago

rupl commented 8 years ago

As reported by https://snyk.io/test/github/rupl/bustashape

rupl commented 8 years ago

The report boils down to two problems: browser-sync uses deps with problems, and the version of Socket.io is out of date.

BS is only for my local use and the commands are never running remotely so I will ignore that for now, but I need to revisit the comments I left in the code to address the regressions caused when upgrading to Socket.io 1.4.0

rupl commented 8 years ago

Room names broke when upgrading, so unfortunately this blocks development of pretty much all DB-related issues. I didn't expect such bad breakage to occur during a minor version upgrade..

rupl commented 8 years ago

Lol this was completely my fault. While digging into why rooms stopped working I realized I have been opening two connections per client. sheesh. No idea why it worked at all in the first place!

Cleaning up my poor initialization process fixed everything!

rupl commented 8 years ago

\o/ 🎉