search

rupok / flexia

A modern lightweight and versatile theme for WordPress with the endless customization options through Customizer.
https://flexia.pro
11 stars 6 forks source link

Overly aggressive escaping in 2.0 breaking multi-level breadcrumbs #32

Open FPCSJames opened 4 years ago

FPCSJames commented 4 years ago

In 2.0, most instances of $delimiter and other static variables in flexia_breadcrumbs() are wrapped in esc_attr(). This is causing breadcrumbs to be output as text containing < and > instead of valid tags.

There is no need to escape these variables. There is no way for the administrator or a developer to modify their contents (a filter, a Customizer option, etc.). All the addition of these escapes does is break the code, not solve any problem.

rupok commented 4 years ago

Hey @FPCSJames Thanks for reporting. Fixed the issue and will release an update soon.

Thanks!