rurban / smhasher

Hash function quality and speed tests
https://rurban.github.io/smhasher/
Other
1.85k stars 178 forks source link

Typos in README summary table? #34

Closed mcaceresb closed 7 years ago

mcaceresb commented 7 years ago

It seems typos were introduced to the README summary table in commit https://github.com/rurban/smhasher/commit/00a4e5ab6bfb7b25bd3c7cf915f68984d4910cfd.

I could be reading it wrong, but the "Quality problems" column in lines 49 through 69 appears to be shifted one row up for a few hashes: i.e. the problems noted correspond to the hash one row down. In commit https://github.com/rurban/smhasher/commit/00a4e5ab6bfb7b25bd3c7cf915f68984d4910cfd, a hash was added but the quality problems column does not appear to have been copied correctly.

The hashes affected are:

rurban commented 7 years ago

Oops, you are right. I shifted it accidently by copy&pasta. City64 has unexpectedly indeed more collision problems then City32.