ruricolist / serapeum

Utilities beyond Alexandria
MIT License
420 stars 41 forks source link

Maybe include WITH-BRANCHING #103

Closed phoe closed 2 years ago

phoe commented 2 years ago

https://github.com/phoe/with-branching

Someone pointed out to me that this utility basically extends serapeum:with-boolean with operators that can avoid "deleting unusable code" warnings. This, and a bit of syntax sugar for having multiple booleans.

Would you consider merging my code into Serapeum? I see a possible way forward like this:

ruricolist commented 2 years ago

I will look into it as soon as I have a chance. I would definitely like to get rid of those unusable code warnings if possible.

phoe commented 2 years ago

OK - my code isn't rocket science, as a recent Hacker News comment mentioned. You should be able to figure everything out by macrostepping the test cases.

ruricolist commented 2 years ago

I would definitely like to merge this into Serapeum.

phoe commented 2 years ago

OK - do you have the time to modify my code and tests yourself (it should be clean enough), or would you prefer if I prepared a PR later?

ruricolist commented 2 years ago

A PR makes more sense to me, if you have time. Your plan looks good.

phoe commented 2 years ago

OK, should be able to do this tomorrow or so.

phoe commented 2 years ago

105 - see the questions in the PR.

phoe commented 2 years ago

Closed via #105.