search

ruricolist / serapeum

Utilities beyond Alexandria
MIT License
415 stars 41 forks source link

Chore: Import symbols instead use packages #171

Closed kilianmh closed 1 month ago

kilianmh commented 1 month ago

Import necessary symbols from alexandria, split-sequence, parse-number, tcr.parse-declarations-1.0, instead of using the packages.

Loading and tests are succeeding. Hopefully there are no symbols left to import.

Maybe the exported symbols should be in the beginning now for readability?

ruricolist commented 1 month ago

What is the benefit here?

kilianmh commented 1 month ago

For someone trying to understand the source code, they find with one search where an external symbol is coming from and do not need to guess. It's a long list of symbols from Alexandria, so the location is added here. Maybe the export clause could be in the front (if compatible with package-locks)?

Alternatively, introducing package-local-nicknames such as proposed here (mainly for alexandria) might be an option.

ruricolist commented 1 month ago

I see, the goal is discoverability rather than guarding against new symbols being exported (unlikely for Alexandria).